Xbox one recent broken, going to buy new Xbox one x. Am I able to swap hard drives?

Hi, switching off hard-drives isn't possible.

All your progress will be stored as long as you use the same account in the new Xbox One X.

You cannot switch hard drives between consoles as they are integrated into the console housing. But yes, you are able to carry over the game to your new console. What you can do is re-download the game onto your new console, games are tied to the account
that purchased it so simply log in to your account on the new console and you can download Fifa 18! Alternatively you can use a compatible external hard drive, move the game to the drive, then connect that drive to your new console to play the game.

Not likely as they are limited run items. Best bet is to buy a broken xbox one x on eBay and swap the case.

Mine is plugged into the back USB and I am able to carry it between Xbox one's

If you don't want to lose your games and you can afford it buy a new drive / borrow one and format it on the Xbox One S and then try it on the S.

I have had no problem going out an buying brand name 2.5 USB3 Ext drives, formatting them and using them.

The only way to tell if it is going to work, is to format the Ext. drive on the new X.

Did they charge you the $99 for repairing the unit or did they at least offer to repair it free? I'm thinking that if I have to shell out the $99 just to be able to use xbox live again, I'll just buy a new one and swap the hard drive over.