Will i need all access to upgrade to the series x from my xbox s all digital

It's not a requirement. You can just buy a Series X.

You have names mixed up. There are no consoles named the Xbox One Series S or Xbox One Series X.

The Xbox One/One S/One X all have a disc drive.

The Xbox One S All Digital Edition does not have a disc drive.

The Xbox Series X has a disc drive.

The Xbox Series S does not have a disc drive.

All the consoles can play backward compatible games. The Series S and One S all digital edition can only play games digitally downloaded.

The other consoles can play games from disc and from digitally downloaded,

I hope this clears things up for you.

To clarify the issue of mailing back hardware, the point of All Access was originally to allow people tp buy an Xbox One on credit and then return the One to upgrade to a Series S/X without further charges. You can also just buy a Series S/X through All Access and wouldn't need to send in any hardware. The 34.99 charge includes both Ultimate and the monthly payment for the console.

From what I can tell, to access the Series X version of the game, you need the Cross-Gen bundle...once you buy that, you should then be able to download and install the Series X version. Without the cross-gen bundle it will, presumably, just install the XB1 version

From the Store page:

"For digital owners of the Call of Duty®: Black Ops Cold War Standard Edition, this upgrade will unlock the Call of Duty®: Black Ops Cold War Cross-Gen Bundle, giving access to the Xbox Series X|S version of the game. After upgrade purchase, search in the Xbox store for the Call of Duty®: Black Ops Cold War - Cross-Gen Bundle to install the Xbox Series X|S version of the game."

I'd like to keep the All access (since I have 1 year of gamepass left), and upgrade my console to the X series. I just didn't see any specific trading options for S to X Series.