Should I buy xbox one s in 2019?

Simply answer is if you want to then do it

If you already have an xbox that wrks just save your money but if you dnt have any xbox one or even any of the current competitor console eithet i would deff look into an xbox one s esp if you see any bundle deals and or sales cause a yr and a half still.long
time to not have any games to play with

Really depends on how you feel about the games you want to play and also the amount you want to spend on consoles in the next few years. Unless you have plans to buy the Scarlett as soon as it launches then it might be best to get the Xbox one X for now
as there are some decent prices + deals for it at the moment, then you could hold out a bit longer until scarlett has more games you might want to play as well. But like I said, depends on your needs and what will be suitable for the budget as well. Whichever
you go for I hope you enjoy your gaming on it!

Happy Gaming!

If it's cheap. It also depends how much you game. If alot, I would save extra for the X.

It depends how much you either want or need a new console, and the all digital one is a good deal and comes with preloaded games.