Please help my account keeps failing to sync data when I open minecraft.

Check the version of Minecraft you are using. I know they recently pushed out a version that wasn't supposed to go out. Not everyone got it, but it was causing various issues. The post on twitter said they are working on a fix.

I found this article about it.

Minecraft 1.11

I do not think it has anything to do with the cloud because the message comes up on minecraft and not on the xbox.

Hi there,

sorry to hear you having an issue with syncing your data.

I have attached a support guide for you to use:Syncing Xbox One game saves to the cloud error messages

Hello!

It sounds like your live account on your computer is failing to sync up correctly. I would try signing out of your account on the Xbox App, Microsoft store, and in Minecraft (if you're able to). Reboot your computer, then sign back into everything and
see if it syncs up correctly.

You might want to make a
backup of your save files and then clear them out locally. That link has an answer to where they are saved with some other bits of information that might be helpful. Even though it's showing up in Minecraft, the saves it's syncing are still Xbox Live
related.

But I might ask if you might have known if you accidently downloaded the Minecraft 1.11 beta? It was erroneously pushed to some people that were not on the Insider builds, which can cause some issues with your worlds opening. Don't think it directly tracks
to the issue you're seeing, but might be worth looking into what build you are currently on at the start screen of Minecraft. Resolving that involves deleting the game and then downloading it from the store.