Past purchases on Xbox One Console from old account?

If it matters I think it has something to do with the Cloud Storage thing because it has a little cloud icon on one of the games in my library or whatever and says I can download it. So how can I clear my Cloud Storage off my Xbox One?

You can purchase it anyway you want. If you purchase it from the new account, you'll want to set one of the consoles as the Home for that account in order to share it with any other accounts. If you purchase it from the old account, it'll automatically
download on the Home console for that account so it doesn't matter which console you purchase the game from.

Was he playing on the old console or the new one? He can only share the games on the Home console.

He is playing on the new Xbox on his account not set to home. I'm playing on the old xbox on my account set to home. Right now the only way it seems to work is with him playing on my account on the new xbox and me playing his account
on the old one. All games have been purchased on my account.

Then you need to set whichever console he is playing on as your Home console.

So set the new Xbox to "home" and remove "home" from the old one?

Hello!

Sometimes one other thing can cause the problem is that, if you are under 18 (or 21) years old, you can not purchase the backward compatible games from the Xbox One console and from the Website and it don't matter if your account is an "adult" account or
not, but if you have access to an Xbox 360 you should be able to purchase the games you want from there.

The account that originally purchased it can still use it, but other accounts (on the same console) can't. On the old console it was actually possible to play add ons purchased with another account