Not visible

Were you signed into the appropriate account on your PC when you redeemed the code? If you visit the game's store page on your Xbox One console, does it give you the option to download or does it ask to purchase the game? For further assistance with verifying
if you own specific content, please reach out to our chat support team through our
Contact Us page.

Thanks!

No, they said it would be a visible rank specifically in Halo Waypoint. That means its not visible in the game itself.

Secondly they didn't say visible to who as far as we know it will still be visible only to you like they said originally it would be.

^^How does it allow for more visibility? Are the feedback forums not visible enough?

Is it possible they're appearing offline? To check, have them go to their profile and the first option is (for me) 'Appear Offline'. It's possible they pressed it by mistake and it would explain why you can't see them.

Have you also tried removing them from your favourites list? It seems to be a possible cause for your issue so removing them from that list might rectify it. You could also try removing them as friends and then readding them.

Let me know how you get on and we can go from there

Sorry to leave this for so long, but it took a while for my buddy and I to sync up our gaming. The "remove friend then add friend" accomplished nothing. I still couldn't see him.

However there is a happy ending to this story. He happened to get on his Xbox 360 where he had his profile set to "always appear offline." Well apparently this carries over to the One (and overrides its settings). We tried every permutation of settings
on the One, but when he changed his 360 settings...presto. I will try it with my other friend to confirm that is the issue in two out of two cases, but I think that is the thing.

tl:dr version: Check your Xbox 360 settings to make sure it isn't set to "always offline."