None of my friends can join my minecraft world

This solved my problem my nat was not open thanks

Thank you so much for the detailed information. To isolate the issue, can you join their world without any issues?

This is every world. And yes i have reset my game and xbox

Hi, I hope you're doing great out there. I am an Independent advisor and I am here to help you in regard to your concern.

I would like to clarify, is this happening with a specific world or in every world that you have made?

Can you please validate if your NAT Type is OPEN?

Settings > General > Network Settings > Test NAT Type.

If it's not OPEN you may need to perform an extended powercycle and reset your network hardware by following the steps below:

1. Unplug the power cable from the back of the router, modem, or gateway for 5 minutes. If you have a router and a modem, unplug the power cable from both devices.

2. Press and hold the Xbox button on your console for 10 seconds or until it turns off then wait for 2 minutes before turning it on again.

3. After 5 minutes, plug the modem or gateway in first, and wait for all the lights to return to their normal state.

4. If you are using a router, plug in the router and wait for all the lights to return to their normal state.