I have two xbox ones and xbox live gold is only working on one of them

You can only be signed in on one system at a time I think.

Have you tried logging out and shutting off your currently working xbox? then try logging in on the other one.

If you are using your account (one which bought the live) on both of them it must be working. Live is connected to account, not console. But, if you want to share your live you can only do that on one console with the option to make it your home box. Anyone
else, with their accounts, can share your live. Problem is, you can only have one console as your home console.

here is the link on how to make your console your home console. So, to make things short. Sign in on one console with an account which bought live. Make it a home console for that account. All other accounts should be able to share your games and subscriptions
like live, game pass or ultimate. On the other console, you can again login with an account that bought the live and you can use it. But only that account can use live.

As others have noted, you can only have one set as your Home Xbox, which will always have Gold active on it once your account is set on this console and you have Gold on your account. For the other console, it will only show your Gold when you manually
sign in and play on it. If you mean that you are having issues if someone else in your household wants to play on the second console (which is not your Home Xbox) and they cannot use your Gold, then this is correct. They would have to play on their account
on your Home Xbox for the Gold to show active.

Well the account with gold will have gold no matter the xbox it's on as long as its signed in it does not have to be homed for the gold but the account needs to be signed in for other accounts to have gold no matter what

You set one console as your home console and the other one has to be constantly logged in to have Gold benefits when you want to play. You can't be signed in on both at the same time with the same account afaik.

If one Xbox is used by a family member or roommate make sure you set that one as the "Home" console, they will get Gold benefits when they log into their own account. Then you can use the other Xbox by regularly logging in with your own account, have Gold
benefits and can play with the other person on your second ("Home") Xbox.